Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9464817
or point your web browser to
http://mondrian/9464817
to review the following code:
Change 9464817 by stevebl...@steveblock-gears3 on 2008/12/18 13:57:43 *pending*
Adds autoupdater to Gears for Opera Mobile. Mailed on behalf of Opera.
R=andreip
[email protected],[email protected]
DELTA=12 (12 added, 0 deleted, 0 changed)
OCL=9464817
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#2 edit
12 delta lines: 12 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 9464817
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9464817 by stevebl...@steveblock-gears3 on 2008/12/18 13:57:43 *pending*
Adds autoupdater to Gears for Opera Mobile. Mailed on behalf of Opera.
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#2 edit
==== //depot/googleclient/gears/opensource/gears/base/opera/opera_utils.cc#2 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/base/opera/opera_utils.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/base/opera/opera_utils.cc
2008-12-18 13:59:14.000000000 +0000
+++ googleclient/gears/opensource/gears/base/opera/opera_utils.cc
2008-12-18 13:56:51.000000000 +0000
@@ -33,6 +33,11 @@
#include "gears/ui/common/settings_dialog.h"
#include "third_party/opera/opera_callback_api.h"
#include "third_party/opera/opera_worker_interface.h"
+
+#ifdef OS_WINCE
+#include "gears/installer/common/cab_updater.h"
+static const char16* kGuid = L"%7B000C0320-09CE-4D7E-B3C9-66B2ACB7FF80%7D";
+#endif
// Implementation of the wrapper class for the native opera worker threads
class OperaWorkerThreadImpl : public OperaWorkerThreadInterface {
@@ -124,6 +129,13 @@
ThreadId browser_thread) {
opera_api_ = opera_api;
browser_thread_ = browser_thread;
+
+#ifdef OS_WINCE
+ HWND opera_window = ::FindWindow(L"Opera_MainWndClass", NULL);
+
+ static CabUpdater updater;
+ updater.Start(opera_window, kGuid);
+#endif
}
// static
