Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9480084
or point your web browser to
http://mondrian/9480084
to review the following code:
Change 9480084 by stevebl...@steveblock-gears3 on 2008/12/19 13:46:43 *pending*
Updates installer package for Gears for Opera Mobile. Mailed on behalf
of Opera.
R=andreip
[email protected],[email protected]
DELTA=29 (27 added, 0 deleted, 2 changed)
OCL=9480084
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#2
edit
29 delta lines: 27 added, 0 deleted, 2 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9480084 by stevebl...@steveblock-gears3 on 2008/12/19 13:46:43 *pending*
Updates installer package for Gears for Opera Mobile. Mailed on behalf
of Opera.
Affected files ...
... //depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#2
edit
====
//depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4#2 -
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
====
# action=edit type=text
--- googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
2008-12-19 13:51:41.000000000 +0000
+++ googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4
2008-12-19 13:46:43.000000000 +0000
@@ -17,12 +17,22 @@
^,^1^,^1^,^m4_dnl
BuildOutputDirectory="bin-opt\wince-arm\opera"
^)
+ImageDirectory="ui\common"
+
SetupDll="setup.dll"
-GearsDll="PRODUCT_SHORT_NAME_UQ.dll"
+GearsDll="gearsop.dll"
PermissionsDialog="permissions_dialog.html"
SettingsDialog="settings_dialog.html"
ShortcutsDialog="shortcuts_dialog.html"
-InstallDir="\Application Data\Opera 9.5"
+Blank="blank.gif"
+ButtonBg="button_bg.gif"
+ButtonCornerBlack="button_corner_black.gif"
+ButtonCornerBlue="button_corner_blue.gif"
+ButtonCornerGrey="button_corner_grey.gif"
+Icon32x32="icon_32x32.png"
+LocalData="local_data.png"
+LocationData="location_data.png"
+InstallDir="\Application Data\Opera 9.5 Beta"
[CEStrings]
; Must be different from that for Gears for IE to avoid conflicts.
@@ -32,6 +42,7 @@
[SourceDisksNames]
1=,"DllSourceDirectory",,%BuildOutputDirectory%
2=,"HtmlSourceDirectory",,%BuildOutputDirectory%\genfiles
+3=,"ImageSourceDirectory",,%ImageDirectory%
; The files that will be in the CAB
[SourceDisksFiles]
@@ -40,6 +51,14 @@
%PermissionsDialog%=2 ; In HtmlSourceDirectory
%SettingsDialog%=2 ; In HtmlSourceDirectory
%ShortcutsDialog%=2 ; In HtmlSourceDirectory
+%Blank%=3 ; In ImageSourceDirectory
+%ButtonBg%=3 ; In ImageSourceDirectory
+%ButtonCornerBlack%=3 ; In ImageSourceDirectory
+%ButtonCornerBlue%=3 ; In ImageSourceDirectory
+%ButtonCornerGrey%=3 ; In ImageSourceDirectory
+%Icon32x32%=3 ; In ImageSourceDirectory
+%LocalData%=3 ; In ImageSourceDirectory
+%LocationData%=3 ; In ImageSourceDirectory
; The destination directories for the files that will be in the CAB
[DestinationDirs]
@@ -55,6 +74,14 @@
%PermissionsDialog%,%PermissionsDialog%,,0
%SettingsDialog%,%SettingsDialog%,,0
%ShortcutsDialog%,%ShortcutsDialog%,,0
+%Blank%,%Blank%,,0
+%ButtonBg%,%ButtonBg%,,0
+%ButtonCornerBlack%,%ButtonCornerBlack%,,0
+%ButtonCornerBlue%,%ButtonCornerBlue%,,0
+%ButtonCornerGrey%,%ButtonCornerGrey%,,0
+%Icon32x32%,%Icon32x32%,,0
+%LocalData%,%LocalData%,,0
+%LocationData%,%LocationData%,,0
; The action to take during installation
[DefaultInstall]
