========================================================================
http://mondrian.corp.google.com/file/9480084///depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4?a=1
File //depot/googleclient/gears/opensource/gears/installer/wince_cab_op.inf.m4 
(snapshot 1)
------------------------------------
Line 20: ImageDirectory="ui\common"
I think that all files that go into the CAB should come from the build output
directory. You can use M4 to copy files from a source directory to the build
output directory.
------------------------------------
Line 23: GearsDll="gearsop.dll"
Add a '[naming]' comment.
------------------------------------
Line 34: LocationData="location_data.png"
I don't think you've sent these files yet. I suggest we add them to ui\opera. It
would be good to name the variables XXXImage for clarity too.
------------------------------------
Line 61: %LocationData%=3        ; In ImageSourceDirectory
Tabs and alignment.
========================================================================

-- 
To respond, reply to this email or visit http://mondrian.corp.google.com/9480084

Reply via email to