Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 9481047
or point your web browser to
http://mondrian/9481047
to review the following code:
Change 9481047 by stevebl...@steveblock-gears3 on 2008/12/19 16:01:55 *pending*
Updates unit tests to work with Opera Mobile. Mailed on behalf of Opera.
R=andreip
[email protected],[email protected]
DELTA=10 (6 added, 0 deleted, 4 changed)
OCL=9481047
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js#2
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js#3
edit
10 delta lines: 6 added, 0 deleted, 4 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9481047 by stevebl...@steveblock-gears3 on 2008/12/19 16:01:55 *pending*
Updates unit tests to work with Opera Mobile. Mailed on behalf of Opera.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js#2
edit
...
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js#3
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js#2
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js
2008-12-17 19:51:45.000000000 +0000
+++ googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js
2008-12-19 16:01:56.000000000 +0000
@@ -79,13 +79,15 @@
// Attempt to create a module without calling privateSetGlobalObject.
var localFactory = createLocalFactory();
var buildInfo = checkCanGetBuildInfo(localFactory);
- if (isWince && isIE) {
+ var isWinCE = buildInfo.indexOf('wince') != -1;
+ var isIE = buildInfo.indexOf(';ie') != -1;
+ if (isWinCE && isIE) {
checkCanNotCreateModule(localFactory);
} else {
checkCanCreateModule(localFactory);
}
// Call privateSetGlobalObject and try again.
- if (isWince && isIE) {
+ if (isWinCE && isIE) {
checkCanSite(localFactory);
} else {
checkCanNotSite(localFactory);
@@ -93,7 +95,7 @@
checkCanGetBuildInfo(localFactory);
checkCanCreateModule(localFactory);
// Call privateSetGlobalObject again and check all is well.
- if (isWince && isIE) {
+ if (isWinCE && isIE) {
checkCanSite(localFactory);
} else {
checkCanNotSite(localFactory);
====
//depot/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js#3
-
c:\MyDocs\Gears3/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js
2008-12-19 16:14:25.000000000 +0000
+++ googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js
2008-12-19 16:13:26.000000000 +0000
@@ -39,6 +39,10 @@
var nextValueToRecvFromWorkerId = []; // [worker] -> value
var NUM_REQUEST_LOOPS = 5; // set workers * requests * responses
var NUM_RESPONSES_PER_REQUEST = 100; // >= 10000 to break IE (2007/02/22)
+ if (isWince) {
+ NUM_WORKERS = 5;
+ NUM_RESPONSES_PER_REQUEST = 50;
+ }
var EXPECTED_RESPONSES_PER_WORKER =
NUM_REQUEST_LOOPS * NUM_RESPONSES_PER_REQUEST;
@@ -138,7 +142,7 @@
}
function testGCWithFunctionClosures() {
- if (!isDebug) {
+ if (!isDebug || isNPAPI) {
// This test relies on forceGC(), which only exists in debug builds.
return;
}
