Just a couple of comments. Stig, if you're happy I can make the changes and submit.
======================================================================== http://mondrian.corp.google.com/file/9481047///depot/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js?a=1 File //depot/googleclient/gears/opensource/gears/test/testcases/factory_siting_tests.js (snapshot 1) ------------------------------------ Line 83: var isIE = buildInfo.indexOf(';ie') != -1; None of these changes are required. isWince and isIE are defined in assert.js. ======================================================================== http://mondrian.corp.google.com/file/9481047///depot/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js?a=1 File //depot/googleclient/gears/opensource/gears/test/testcases/workerpool_tests.js (snapshot 1) ------------------------------------ Line 145: if (!isDebug || isNPAPI) { It looks like forceGC() isn't implemented for the main thread on NPAPI or for workers in Opera. So you're right that this test isn't testing much in these cases. However, I think it's safe to leave it enabled, as is currently the case for NPAPI, as it will still pass. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9481047
