Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 9954849
or point your web browser to
http://mondrian/9954849
to review the following code:
Change 9954849 by nigel...@nigeltao-srcgears2 on 2009/02/02 16:48:27 *pending*
desktop.getDragData should return null, rather than undefined,
if there is no data. This makes it consistent with the other
Gears APIs.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9954849
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#73 edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9954849
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9954849 by nigel...@nigeltao-srcgears2 on 2009/02/02 16:48:27 *pending*
desktop.getDragData should return null, rather than undefined,
if there is no data. This makes it consistent with the other
Gears APIs.
Affected files ...
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#73 edit
==== //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#73 -
/home/nigeltao/srcgears2/googleclient/gears/opensource/gears/desktop/desktop.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/desktop.cc 2009-02-02
16:49:30.000000000 +1100
+++ googleclient/gears/opensource/gears/desktop/desktop.cc 2009-02-02
16:41:06.000000000 +1100
@@ -913,7 +913,7 @@
if (data_available) {
context->SetReturnValue(JSPARAM_OBJECT, result.get());
} else if (error.empty()) {
- context->SetReturnValue(JSPARAM_UNDEFINED, NULL);
+ context->SetReturnValue(JSPARAM_NULL, NULL);
} else {
context->SetException(error);
}
