On Thu, 29 Jan 2009 12:46:41 +0100, Andrei Popescu <[email protected]>  
wrote:

> ========================================================================
> http://mondrian.corp.google.com/file/9879962///depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4?a=3
> File  
> //depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4
>   
> (snapshot 3)
> ------------------------------------
> Line 424: // Do not resize on Opera Mobile, let the browser resize  
> automatically
> Most of the time you just check for browser.opera, not browser.wince &&
> browser.opera. Are you sure those other checks are all correct (e.g. the
> wrapDomain() ones). Just checking.
> ------------------------------------
> Line 283: // Do not resize on Opera Mobile, let the browser resize  
> automatically.
> same question here...
> ========================================================================

The correct check would be for browser.opera && browser.wince. Steve has  
appiled this check at all places as far as I know.

> ========================================================================
> http://mondrian.corp.google.com/file/9879962///depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4?a=3
> File  
> //depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4
>   
> (snapshot 3)
> ------------------------------------
> Line 34: <title></title>
> Empty title? What for?

Without a title tag document.title has no effect in the Opera Browser.  
Thats the reason we need the tag to be present in the HTML files.

>
Deepak.

Reply via email to