On Wed, 28 Jan 2009 13:33:09 +0100, Steve Block <[email protected]> wrote:
> Hello andreip, > > I'd like you to do a code review. Please execute > g4 diff -c 9879962 > > or point your web browser to > http://mondrian/9879962 > > to review the following code: > > Change 9879962 by stevebl...@steveblock-gears2 on 2009/01/27 19:10:40 > *pending* > > Modifies HTML dialogs for Opera. Mailed on behalf of Opera. > > Thanks for the replies Deepak. > > I've made all of the changes I suggested. I tested on other > browsers and it's OK to add the empty title tag in all cases. Let me > know if you're happy with the changes and I'll submit. Thanks for the changes Steve. All the changes look good to me, please submit them. > > R=andreip > [email protected],[email protected],[email protected] > DELTA=61 (51 added, 2 deleted, 8 changed) > OCL=9879962 > > Affected files ... > > ... > //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.css#6 > edit > ... > //depot/googleclient/gears/opensource/gears/ui/common/html_dialog.js#13 > edit > ... > //depot/googleclient/gears/opensource/gears/ui/common/permissions_dialog.html_m4#7 > > edit > ... > //depot/googleclient/gears/opensource/gears/ui/common/settings_dialog.html_m4#6 > > edit > ... > //depot/googleclient/gears/opensource/gears/ui/common/shortcuts_dialog.html_m4#9 > > edit > > 61 delta lines: 51 added, 2 deleted, 8 changed > > If you can't do the review, please let me know as soon as possible. > During > your review, please ensure that all new code has corresponding unit > tests and > that existing unit tests are updated appropriately. Visit > http://www/eng/code_review.html for more information. > > This is a semiautomated message from "g4 mail". Complaints or > suggestions? > Mail [email protected]. -- Deepak Prabhakara Developer, Windows Mobile Opera Software +47-96831977
