Hello zork,
I'd like you to do a code review. Please execute
g4 diff -c 9985746
or point your web browser to
http://mondrian/9985746
to review the following code:
Change 9985746 by mpcompl...@mpcomplete-gears on 2009/02/03 15:27:07 *pending*
Fix a crash bug with AutoUpdateSyncMessage.
R=zork
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=9985746
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h#2
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 9985746
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 9985746 by mpcompl...@mpcomplete-gears on 2009/02/03 15:27:07 *pending*
Fix a crash bug with AutoUpdateSyncMessage.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h#2
edit
====
//depot/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h#2
-
C:\src\gears/googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h
2009-02-03 15:27:15.000000000 -0800
+++ googleclient/gears/opensource/gears/localserver/chrome/update_task_cr.h
2009-02-03 15:19:09.000000000 -0800
@@ -124,7 +124,7 @@
// Serializable registration
static Serializable *New() {
- return new AutoUpdateMessage;
+ return new AutoUpdateSyncMessage;
}
static void Register() {
Serializable::RegisterClass(SERIALIZABLE_AUTOUPDATE_SYNC_MESSAGE, New);
