======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/desktop.h?a=3 File //depot/googleclient/gears/opensource/gears/desktop/desktop.h (snapshot 3) ------------------------------------ Line 186: // IN: Event event, bool acceptance stray tabs on these 3 lines. ======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc?a=3 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc (snapshot 3) ------------------------------------ Line 270: SetDragCursor(module_environment, event_as_js_object, cursor_type, error_out); If this call set error_out, is there any reason to go on? ======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc (snapshot 5) ------------------------------------ Line 187: SetDragCursor(module_environment, event, cursor_type, error_out); So if this call set error_out, is there any reason to go on? ------------------------------------ Line 211: if (type == DRAG_AND_DROP_EVENT_INVALID) { Use an else clause? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/9955210
