======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/desktop.h?a=3 File //depot/googleclient/gears/opensource/gears/desktop/desktop.h (snapshot 3) ------------------------------------ Line 186: // IN: Event event, bool acceptance On 6 Feb, noel wrote: > stray tabs on these 3 lines.
Done. ======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc?a=3 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc (snapshot 3) ------------------------------------ Line 270: SetDragCursor(module_environment, event_as_js_object, cursor_type, error_out); On 6 Feb, noel wrote: > If this call set error_out, is there any reason to go on? No, but I don't really go on anyway, I just combined (via &&) the two if-conditions into one check. Still, I've moved the error_out check up a couple of lines. ======================================================================== http://mondrian.corp.google.com/file/9955210///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc (snapshot 5) ------------------------------------ Line 187: SetDragCursor(module_environment, event, cursor_type, error_out); On 6 Feb, noel wrote: > So if this call set error_out, is there any reason to go on? Done. ------------------------------------ Line 211: if (type == DRAG_AND_DROP_EVENT_INVALID) { On 6 Feb, noel wrote: > Use an else clause? I don't see using an else being a major win. The code as is is consistent with the "if an error occurs, then return early" model. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/9955210
