======================================================================== http://mondrian.corp.google.com/file/10257353///depot/googleclient/gears/opensource/gears/workerpool/location.cc?a=1 File //depot/googleclient/gears/opensource/gears/workerpool/location.cc (snapshot 1) ------------------------------------ Line 55: const std::string16 &url = module_environment_->security_origin_.full_url(); On 7:50 pm, aa wrote: > Consider caching the parsed representation so that this work doesn't need to be > done over and over.
Done. ------------------------------------ Line 57: url_parse::ParseStandardURL(url.c_str(), url.length(), &parsed); On 7:51 pm, aa wrote: > Assert this succeeds. ParseStandardURL returns void, and its documentation (in third_party/googleurl/src/url_parse.h line 208) says, "[this function] can not fail, they will always do their best at interpreting the input given". ------------------------------------ Line 90: // The HTML5 spec (*) says that we should return "http:" instead of "http", On 7:53 pm, aa wrote: > Great comment. You may want to also note somewhere that the HTML5 spec > recommends this location property > (http://www.whatwg.org/specs/web-workers/current-work/#worker-locations). Class comment added to location.h. ------------------------------------ Line 114: component_type == url_parse::Parsed::REF) { On 7:56 pm, aa wrote: > Indent this under the previous 'component_type'. Done. ======================================================================== http://mondrian.corp.google.com/file/10257353///depot/googleclient/gears/opensource/gears/workerpool/location.h?a=1 File //depot/googleclient/gears/opensource/gears/workerpool/location.h (snapshot 1) ------------------------------------ Line 33: : public ModuleImplBaseClass { On 7:47 pm, aa wrote: > This could fit on the previous line. Done. ------------------------------------ Line 73: void GetComponent( On 7:54 pm, aa wrote: > This method could use some comments. I have no idea what host_port does. Comment added. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10257353
