LGTM On Tue, Feb 24, 2009 at 2:07 AM, Nigel Tao <[email protected]> wrote: > Line 57: url_parse::ParseStandardURL(url.c_str(), url.length(), &parsed); > On 7:51 pm, aa wrote: >> Assert this succeeds. > > ParseStandardURL returns void, and its documentation (in > third_party/googleurl/src/url_parse.h line 208) says, "[this function] can not > fail, they will always do their best at interpreting the input given".
Right, I meant assert that the URL was valid. I think there is an is_valid() method or something. I guess what you're saying, though, is that we have no way to guarantee that the URL is valid. Ok, nevermind.
