======================================================================== http://mondrian.corp.google.com/file/10229053///depot/googleclient/gears/opensource/gears/base/npapi/browser_utils.cc?a=2 File //depot/googleclient/gears/opensource/gears/base/npapi/browser_utils.cc (snapshot 2) ------------------------------------ Line 35: #elif ANDROID OS_ANDROID ------------------------------------ Line 172: bool ret = false; true ------------------------------------ Line 182: return false; true (and in the rest of the error cases) ======================================================================== http://mondrian.corp.google.com/file/10229053///depot/googleclient/gears/opensource/gears/localserver/managed_resource_store_module.cc?a=2 File //depot/googleclient/gears/opensource/gears/localserver/managed_resource_store_module.cc (snapshot 2) ------------------------------------ Line 203: if (!BrowserUtils::IsOnline(context->js_context())) { Not sure about this one. I do agree that the call can be expensive (especially when we're in a worker). Maybe add a comment about this? We could ask michaeln for a second opinion as well? ======================================================================== http://mondrian.corp.google.com/file/10229053///depot/googleclient/gears/opensource/gears/localserver/npapi/async_task_np.cc?a=2 File //depot/googleclient/gears/opensource/gears/localserver/npapi/async_task_np.cc (snapshot 2) ------------------------------------ Line 30: #include "gears/base/android/browsing_context_android.h" wrong order ------------------------------------ Line 368: #ifdef ANDROID OS_ANDROID ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/10229053
