========================================================================
http://mondrian.corp.google.com/file/10229053///depot/googleclient/gears/opensource/gears/localserver/managed_resource_store_module.cc?a=3
File 
//depot/googleclient/gears/opensource/gears/localserver/managed_resource_store_module.cc
 (snapshot 3)
------------------------------------
Line 204: // in async_task, we check it here.
This changes the semantics of the method somewhat. Upon return either a check
should be running or should just have finished. If a caller had set the event
handlers prior to calling checkForUpdate, they should expect them to be called.
But that won't happen with this change. Also the updateStatus lastErrorMessage
and lastUpdateCheckTime properties will behave differently for updates initiated
thru this method call.

What is the reason for implementing IsOnline at this time? Since chrome doesn't
really have a notion of 'online' we don't bother at all and always consider the
system as online.

Is there a better way of getting this 'bit' out of the hosting browser than
groping the 'navigator' object via DOM and script?

AsyncTasks are often started not in the context of a page, and can run for a
duration that spans multiple page navigations. Is the techinique you're using to
poke at navigator.online resilient to this?
========================================================================

-- 
To respond, reply to this email or visit 
http://mondrian.corp.google.com/10229053

Reply via email to