Hello zork,
I'd like you to do a code review. Please execute
g4 diff -c 10494129
or point your web browser to
http://mondrian/10494129
to review the following code:
Change 10494129 by micha...@michaeln-scour2 on 2009/03/16 12:11:41 *pending*
LocalServer cache hit logging utility.
A browser specific environement variable enables the log file
* GEARS_LOCALSERVER_LOGFILE_ie
* GEARS_LOCALSERVER_LOGFILE_firefox
* GEARS_LOCALSERVER_LOGFILE_chrome
The env variable value should be a full path to the log file to create.
Each log file is uniqueified by appending ticks to the provided path.
R=zork
CC=gears-internal,[email protected]
DELTA=102 (94 added, 0 deleted, 8 changed)
OCL=10494129
Affected files ...
... //depot/googleclient/gears/opensource/gears/factory/factory_utils.cc#7 edit
... //depot/googleclient/gears/opensource/gears/factory/factory_utils.h#1 edit
...
//depot/googleclient/gears/opensource/gears/localserver/common/localserver_db.cc#20
edit
102 delta lines: 94 added, 0 deleted, 8 changed
Also consider running:
g4 lint -c 10494129
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
