Hello andreip, michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 10462049
or point your web browser to
http://mondrian/10462049
to review the following code:
Change 10462049 by nicolasro...@nicolasroard-tangerine-gears3 on 2009/03/12
19:27:19 *pending*
HTTPRequest refactoring -- we move as much as possible operations to
the child thread to liberate the main thread.
PRESUBMIT=passed
R=andreip,michaeln
[email protected]
DELTA=187 (68 added, 48 deleted, 71 changed)
OCL=10462049
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#12
edit
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h#6
edit
187 delta lines: 68 added, 48 deleted, 71 changed
Also consider running:
g4 lint -c 10462049
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
