Hello benm,
I'd like you to do a code review. Please execute
g4 diff -c 10520539
or point your web browser to
http://mondrian/10520539
to review the following code:
Change 10520539 by andr...@andreip-gearslinux on 2009/03/18 11:58:17 *pending*
Fix busted Android build.
PRESUBMIT=passed
R=benm
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10520539
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/common/localserver_db.cc#22
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 10520539
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10520539 by andr...@andreip-gearslinux on 2009/03/18 11:58:17 *pending*
Fix busted Android build.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/common/localserver_db.cc#22
edit
====
//depot/googleclient/gears/opensource/gears/localserver/common/localserver_db.cc#22
-
/home/andreip/Gears/googleclient/gears/opensource/gears/localserver/common/localserver_db.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/localserver/common/localserver_db.cc
2009-03-18 11:58:46.000000000 +0000
+++ googleclient/gears/opensource/gears/localserver/common/localserver_db.cc
2009-03-18 11:54:50.000000000 +0000
@@ -797,7 +797,7 @@
class QueryMatcher {
public:
- QueryMatcher::QueryMatcher(const char16 *requested_query)
+ QueryMatcher(const char16 *requested_query)
: query(requested_query), parsed(false) {}
// Test the matchQuery.hasAll attribute. An empty value in the match string
