LGTM Nice diagram, you may want to put a reference to that diagram in a comment.
======================================================================== http://mondrian.corp.google.com/file/10462049///depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc?a=6 File //depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc (snapshot 6) ------------------------------------ Line 667: // Exit the state machine loop. 'loop' comment is stale ------------------------------------ Line 1403: // We simply switch the child to the STATE_CHILD_ABORT state. Does the 'interrupt' call cause whatever may be happening on the child thread to unwind reasonably quickly? Just checking. ======================================================================== http://mondrian.corp.google.com/file/10462049///depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h?a=4 File //depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h (snapshot 4) ------------------------------------ Line 344: // is not allowed to modify state_. The comment is stale. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10462049
