Hello andreip, michaeln,
I'd like you to do a code review. Please execute
g4 diff -c 10604605
or point your web browser to
http://mondrian/10604605
to review the following code:
Change 10604605 by nicolasro...@nicolasroard-tangerine-gears3 on 2009/03/25
21:36:10 *pending*
Modify the abort() handling to fix leaking threads in the java side:
- use a newly added abort() function instead of interrupt()
- call interrupt() (which joins the cnx thread) in CHILD_ABORT.
PRESUBMIT=passed
R=andreip,michaeln
[email protected]
DELTA=18 (16 added, 0 deleted, 2 changed)
OCL=10604605
Affected files ...
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.cc#14
edit
...
//depot/googleclient/gears/opensource/gears/localserver/android/http_request_android.h#8
edit
18 delta lines: 16 added, 0 deleted, 2 changed
Also consider running:
g4 lint -c 10604605
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
