Hello aa,
I'd like you to do a code review. Please execute
g4 diff -c 10617721
or point your web browser to
http://mondrian/10617721
(this changelist has been uploaded to Mondrian)
to review the following code:
Change 10617721 by a...@ace-gears2 on 2009/03/26 12:05:54 *pending*
Commenting out flakey test testZeroTimeout which first started failing
after cl 10410384.
PRESUBMIT=passed
R=aa
[email protected],steveblock
DELTA=12 (2 added, 0 deleted, 10 changed)
OCL=10617721
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js#6
edit
12 delta lines: 2 added, 0 deleted, 10 changed
Also consider running:
g4 lint -c 10617721
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10617721 by a...@ace-gears2 on 2009/03/26 12:05:54 *pending*
Commenting out flakey test testZeroTimeout which first started failing
after cl 10410384.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js#6
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js#6
-
c:\gears/googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js
====
# action=edit type=text
--- googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js
2009-03-26 12:08:15.000000000 -0700
+++ googleclient/gears/opensource/gears/test/testcases/geolocation_tests.js
2009-03-26 12:04:14.000000000 -0700
@@ -165,13 +165,15 @@
{maximumAge: 1, gearsLocationProviderUrls: []});
}
-function testZeroTimeout() {
- // A request with a zero timeout should call the error callback immediately.
- function errorCallback(error) {
- assertEqual(error.TIMEOUT, error.code,
- 'Error callback should be called with code TIMEOUT.');
- completeAsync();
- }
- startAsync();
- geolocation.getCurrentPosition(dummyFunction, errorCallback, {timeout: 0});
-}
+// TODO(steveblock): Fix and uncomment this test.
+// Test is flakey when run in worker after CL 10410384.
+//function testZeroTimeout() {
+// // A request with a zero timeout should call the error callback
immediately.
+// function errorCallback(error) {
+// assertEqual(error.TIMEOUT, error.code,
+// 'Error callback should be called with code TIMEOUT.');
+// completeAsync();
+// }
+// startAsync();
+// geolocation.getCurrentPosition(dummyFunction, errorCallback, {timeout: 0});
+//}
