Hello cprince,
I'd like you to do a code review. Please execute
g4 diff -c 10624727
or point your web browser to
http://mondrian/10624727
to review the following code:
Change 10624727 by nigel...@nigeltao-srcgears4 on 2009/03/27 12:43:02 *pending*
Build fixes for 64-bit Ubuntu Hardy (GCC 4.2).
This builds a 64-bit Firefox/Linux Gears installer for Firefox3
only, not Firefox2, since it is simpler to do so, Firefox2 is
approaching end-of-life, and (IIUC) Firefox2 is not part of the
default Ubuntu Hardy install.
64-bittedness versus 32-bittedness is determined by the result
of "gcc -dumpmachine". For example, if you are running a 64-bit
kernel but a 32-bit userspace (including a 32-bit gcc) then
calling make will build the 32-bit Gears installer.
Also, the resultant 64-bit .xpi filename has an explicit ARCH
(i.e. the "-x86_64" in gears-linux-x86_64-dbg-1.2.3.4.xpi).
If building a 32-bit installer, there is no ARCH in the filename,
the same as before.
The binary libraries (e.g. libxpcom.so, libxul.so) that are new
to third_party are copied straight from Ubuntu's /usr/lib64/firefox.
AsyncTask's HandleEvent method was renamed to HandleAsyncTaskEvent,
in order to disambiguate it from the other HandleEvent names in
the source code (there are at least three -- there's a Gears concept
for JSEVENT_UNLOAD, there's the DOM's HandleEvent used in the
NPAPI port, and there's the Gecko event system used in the
Firefox port).
The second parameter to AsyncTask::HandleAsyncTaskEvent was
clarified to be an int, rather than either an int or a void*.
The latter were equivalent on a 32-bit system, but are obviously
not so on a 64-bit system. On inspection, the only uses of the
param arg was either unused (zero) or as an index to an array.
Blob- and file- related changes make casts from size_t to int64
explicit. On 32-bit systems, the cast loses no information. On
64-bit systems, size_t is unsigned and int64 is signed, and so
an implicit cast causes a compiler warning (and we compile with
-Wall -Werror).
The assertion in i18n_strings.cc was removed because it caused
an unused code warning, since the compiler could determine that
the I18NStringKey enum was always <= the ARRAYSIZE(kLocalStrings).
The global std::vector data variable in blob_input_stream_ff_test.cc
was simply unused (and hence causing a compiler warning).
The sqlite fts?_porter.c change was to silence a compiler warning
where the naked a || b; expression was considered unused.
All tests (http://localhost:8001/tester/gui.html) are green, on
Firefox3 / Linux (Ubuntu Hardy x86_64).
PRESUBMIT=passed
R=cprince
[email protected]
DELTA=208 (62 added, 12 deleted, 134 changed)
OCL=10624727
Affected files ...
... //depot/googleclient/gears/opensource/gears/base/common/byte_store.cc#11
edit
...
//depot/googleclient/gears/opensource/gears/base/common/byte_store_test.cc#2
edit
... //depot/googleclient/gears/opensource/gears/base/common/file.cc#7 edit
... //depot/googleclient/gears/opensource/gears/base/common/file_posix.cc#11
edit
...
//depot/googleclient/gears/opensource/gears/base/common/js_runner_ff_marshaling.cc#14
edit
... //depot/googleclient/gears/opensource/gears/base/firefox/install.rdf.m4#3
edit
...
//depot/googleclient/gears/opensource/gears/blob/blob_input_stream_ff_test.cc#4
edit
... //depot/googleclient/gears/opensource/gears/blob/blob_test.cc#14 edit
... //depot/googleclient/gears/opensource/gears/blob/buffer_blob.cc#4 edit
...
//depot/googleclient/gears/opensource/gears/canvas/blob_backed_skia_input_stream.cc#3
edit
... //depot/googleclient/gears/opensource/gears/cctests/test.cc#95 edit
... //depot/googleclient/gears/opensource/gears/desktop/file_dialog.cc#18 edit
...
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#2
edit
... //depot/googleclient/gears/opensource/gears/geolocation/geolocation.cc#74
edit
...
//depot/googleclient/gears/opensource/gears/geolocation/wifi_data_provider_common.cc#9
edit
...
//depot/googleclient/gears/opensource/gears/installer/android/lib_updater.cc#5
edit
...
//depot/googleclient/gears/opensource/gears/installer/android/lib_updater.h#2
edit
...
//depot/googleclient/gears/opensource/gears/localserver/firefox/async_task_ff.cc#16
edit
...
//depot/googleclient/gears/opensource/gears/localserver/firefox/async_task_ff.h#9
edit
...
//depot/googleclient/gears/opensource/gears/localserver/npapi/async_task_np.cc#15
edit
...
//depot/googleclient/gears/opensource/gears/localserver/npapi/async_task_np.h#11
edit
...
//depot/googleclient/gears/opensource/gears/localserver/resource_store_module.cc#15
edit
...
//depot/googleclient/gears/opensource/gears/localserver/resource_store_module.h#6
edit
...
//depot/googleclient/gears/opensource/gears/localserver/safari/async_task_sf.h#7
edit
...
//depot/googleclient/gears/opensource/gears/localserver/safari/async_task_sf.mm#13
edit
... //depot/googleclient/gears/opensource/gears/tools/config.mk#105 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#105 edit
... //depot/googleclient/gears/opensource/gears/ui/common/i18n_strings.cc#2 edit
...
//depot/googleclient/gears/opensource/third_party/gecko_1.9/linux/gecko_sdk/lib64/libxpcom.so#1
add
...
//depot/googleclient/gears/opensource/third_party/gecko_1.9/linux/gecko_sdk/lib64/libxpcomglue.a#1
add
...
//depot/googleclient/gears/opensource/third_party/gecko_1.9/linux/gecko_sdk/lib64/libxpcomglue_s.a#1
add
...
//depot/googleclient/gears/opensource/third_party/gecko_1.9/linux/gecko_sdk/lib64/libxul.so#1
add
...
//depot/googleclient/gears/opensource/third_party/sqlite_google/README.google#4
edit
...
//depot/googleclient/gears/opensource/third_party/sqlite_google/ext/fts1/fts1_porter.c#2
edit
...
//depot/googleclient/gears/opensource/third_party/sqlite_google/ext/fts2/fts2_porter.c#2
edit
208 delta lines: 62 added, 12 deleted, 134 changed
Also consider running:
g4 lint -c 10624727
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
