Hello cprince,
I'd like you to do a code review. Please execute
g4 diff -c 10690324
or point your web browser to
http://mondrian/10690324
to review the following code:
Change 10690324 by nigel...@nigeltao-srcgears5 on 2009/04/02 20:22:17 *pending*
Fix compiler warning (i.e. error) for 64-bit MODE=opt.
All tests (http://localhost/tester/gui.html) are green.
PRESUBMIT=passed
R=cprince
[email protected]
DELTA=24 (23 added, 0 deleted, 1 changed)
OCL=10690324
Affected files ...
... //depot/googleclient/gears/opensource/third_party/gecko_1.9/README.google#6
edit
...
//depot/googleclient/gears/opensource/third_party/gecko_1.9/gecko_internal/xptinfo.h#1
edit
24 delta lines: 23 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 10690324
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
