Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10720314
or point your web browser to
http://mondrian/10720314
to review the following code:
Change 10720314 by stevebl...@steveblock-gears1 on 2009/04/06 12:11:55 *pending*
Renames settings dialog menu entry from 'Gears Settings' to 'Gears' on
Windows Mobile.
This saves screen real estate and 'fixes' issue 661.
R=andreip
[email protected]
DELTA=6 (3 added, 0 deleted, 3 changed)
OCL=10720314
Affected files ...
... //depot/googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc#6 edit
6 delta lines: 3 added, 0 deleted, 3 changed
Also consider running:
g4 lint -c 10720314
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10720314 by stevebl...@steveblock-gears1 on 2009/04/06 12:11:55 *pending*
Renames settings dialog menu entry from 'Gears Settings' to 'Gears' on
Windows Mobile.
This saves screen real estate and 'fixes' issue 661.
Affected files ...
... //depot/googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc#6 edit
==== //depot/googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc#6 -
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc
2009-04-06 12:18:34.000000000 +0100
+++ googleclient/gears/opensource/gears/ui/ie/tools_menu_item.cc
2009-04-06 12:11:59.000000000 +0100
@@ -43,8 +43,11 @@
// On WinCE, LoadString does not support multiple languages, so we can't load
// IDS_REGISTRY_MENU_TEXT.
+ // Note that the menu item must be present in tools_menu_item.rgs, but the
+ // string used there ('Gears Settings') is arbitrary and is not used for
+ // display.
InsertMenu(hmenu, index_menu, MF_BYPOSITION, command_first_,
- L"Gears Settings"); // [naming]
+ L"Gears"); // [naming]
return MAKE_HRESULT(SEVERITY_SUCCESS, FACILITY_NULL, 1);
}
@@ -60,8 +63,8 @@
switch (flags) {
case GCS_VERB:
case GCS_HELPTEXT: {
- strncpy(command_name, "Gears Settings", // [naming]
- command_name_len);
+ strncpy(command_name, "Gears", // [naming]
+ command_name_len);
} break;
case GCS_VALIDATE:
break;
