Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10720112
or point your web browser to
http://mondrian/10720112
to review the following code:
Change 10720112 by stevebl...@steveblock-gears1 on 2009/04/06 11:17:49 *pending*
Adds dependency for .res files on .rgs files for IE and IE Mobile.
R=andreip
[email protected]
DELTA=13 (10 added, 0 deleted, 3 changed)
OCL=10720112
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#106 edit
13 delta lines: 10 added, 0 deleted, 3 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10720112 by stevebl...@steveblock-gears1 on 2009/04/06 11:17:49 *pending*
Adds dependency for .res files on .rgs files for IE and IE Mobile.
Affected files ...
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#106 edit
==== //depot/googleclient/gears/opensource/gears/tools/rules.mk#106 -
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/tools/rules.mk ====
# action=edit type=text
--- googleclient/gears/opensource/gears/tools/rules.mk 2009-04-06
11:49:49.000000000 +0100
+++ googleclient/gears/opensource/gears/tools/rules.mk 2009-04-06
11:48:33.000000000 +0100
@@ -54,7 +54,7 @@
SF_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/safari
OSX_LAUNCHURL_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/launch_url_with_browser
-RUN_GEARS_DLL_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/run_gears_dll
+RUN_GEARS_DLL_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/run_gears_dll
SF_INSTALLER_PLUGIN_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/installer_plugin
VISTA_BROKER_OUTDIR = $(OUTDIR)/$(OS)-$(ARCH)/vista_broker
@@ -158,6 +158,14 @@
$(SQLITE_OBJS:$(OBJ_SUFFIX)=.pp) \
$(THIRD_PARTY_OBJS:$(OBJ_SUFFIX)=.pp)
+RGS_FILES = \
+ $($(BROWSER)_OUTDIR)/genfiles/bho.rgs \
+ $($(BROWSER)_OUTDIR)/genfiles/factory_ie.rgs \
+ $($(BROWSER)_OUTDIR)/genfiles/html_dialog_bridge_iemobile.rgs \
+ $($(BROWSER)_OUTDIR)/genfiles/module.rgs \
+ $($(BROWSER)_OUTDIR)/genfiles/tools_menu_item.rgs \
+ $(NULL)
+
$(BROWSER)_GEN_HEADERS = \
$(patsubst
%.idl,$($(BROWSER)_OUTDIR)/genfiles/%.h,$($(BROWSER)_IDLSRCS))
@@ -777,10 +785,12 @@
# RESOURCE TARGETS
-$(IE_OUTDIR)/%.res: %.rc $(COMMON_RESOURCES)
+# Strictly, only module.res depends on the .rgs files.
+$(IE_OUTDIR)/%.res: %.rc $(COMMON_RESOURCES) $(RGS_FILES)
$(RC) $(RCFLAGS) /DBROWSER_IE=1 $<
-$(IEMOBILE_OUTDIR)/%.res: %.rc $(COMMON_RESOURCES)
+# Strictly, only module.res depends on the .rgs files.
+$(IEMOBILE_OUTDIR)/%.res: %.rc $(COMMON_RESOURCES) $(RGS_FILES)
$(RC) $(RCFLAGS) /DBROWSER_IEMOBILE=1 $<
$(FF2_OUTDIR)/%.res: %.rc $(COMMON_RESOURCES)
