-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Noel Gordon Sent: Monday, April 06, 2009 7:26 PM To: Nigel Tao Cc: [email protected]; [email protected] Subject: Re: a code review: 10719360 Implement path ops in the Gears canvas.
======================================================================== http://mondrian.corp.google.com/file/10719360///depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc?a=1 File //depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc (snapshot 1) ------------------------------------ Line 607: // something different. "Firefox ... something different"? Maybe it's a bug they're trying to fix, I'm sure they're aware of it, but I don't quite see the relevance of that part of the comment. ------------------------------------ Line 619: what does the canvas spec say about the r <= 0 case? ------------------------------------ Line 642: // Path::addArc in WebCore/platform/graphics/skia/PathSkia.cpp. a url would be helpful here: http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/skia/PathSkia.cpp ------------------------------------ Line 656: what does the canvas spec say about the r <= 0 case? ------------------------------------ Line 658: oval.set(x - r, y - r, x + r, y + r); webkit uses SkScalar args in this call, so I was expecting to see a few SkDoubleToScalar() conversions before this oval.set(). Why the difference? ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/10719360
