Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 10734458
or point your web browser to
http://mondrian/10734458
to review the following code:
Change 10734458 by nigel...@nigeltao-srcgears2 on 2009/04/07 20:32:41 *pending*
Remove the v1 drag-and-drop API (also known as the "Gears calls
Web-app" model), since it has been superseded by the v2 API (aka
the "Web-app calls Gears" model).
PRESUBMIT=passed
R=noel
[email protected]
DELTA=2532 (10 added, 2518 deleted, 4 changed)
OCL=10734458
Affected files ...
... //depot/googleclient/gears/opensource/gears/Makefile#242 edit
... //depot/googleclient/gears/opensource/gears/desktop/desktop.cc#84 edit
... //depot/googleclient/gears/opensource/gears/desktop/desktop.h#30 edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_common.h#5
edit
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ie.cc#12
edit
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_base.cc#3
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_base.h#5
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.cc#2
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_cr.h#1
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.cc#21
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ff.h#10
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.cc#20
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_ie.h#12
delete
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.cc#3
delete
...
//depot/googleclient/gears/opensource/gears/desktop/drop_target_registration.h#5
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_sf.cc#5
delete
... //depot/googleclient/gears/opensource/gears/desktop/drop_target_sf.h#2
delete
...
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#4
edit
2532 delta lines: 10 added, 2518 deleted, 4 changed
Also consider running:
g4 lint -c 10734458
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
