Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 10752259
or point your web browser to
http://mondrian/10752259
to review the following code:
Change 10752259 by stevebl...@steveblock-gears2 on 2009/04/08 18:11:51 *pending*
Bug fix from CL 10410606.
Modifies AccessPointDataLess to use public inheritance for std::set.
R=andreip
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=10752259
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/device_data_provider.h#15
edit
1 delta lines: 0 added, 0 deleted, 1 changed
Also consider running:
g4 lint -c 10752259
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 10752259 by stevebl...@steveblock-gears2 on 2009/04/08 18:11:51 *pending*
Bug fix from CL 10410606.
Modifies AccessPointDataLess to use public inheritance for std::set.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/geolocation/device_data_provider.h#15
edit
====
//depot/googleclient/gears/opensource/gears/geolocation/device_data_provider.h#15
-
c:\MyDocs\Gears2/googleclient/gears/opensource/gears/geolocation/device_data_provider.h
====
# action=edit type=text
--- googleclient/gears/opensource/gears/geolocation/device_data_provider.h
2009-04-08 18:54:20.000000000 +0100
+++ googleclient/gears/opensource/gears/geolocation/device_data_provider.h
2009-04-08 18:09:52.000000000 +0100
@@ -154,7 +154,7 @@
// This is to allow AccessPointData to be used in std::set. We order
// lexicographically by MAC address.
-struct AccessPointDataLess : std::less<AccessPointData> {
+struct AccessPointDataLess : public std::less<AccessPointData> {
bool operator()(const AccessPointData &data1,
const AccessPointData &data2) const {
return data1.mac_address < data2.mac_address;
