Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 10747844
or point your web browser to
http://mondrian/10747844
to review the following code:
Change 10747844 by nigel...@nigeltao-srcgears2 on 2009/04/08 15:25:57 *pending*
Implement canvas' globalAlpha and globalCompositeOperation.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=182 (73 added, 86 deleted, 23 changed)
OCL=10747844
Affected files ...
... //depot/googleclient/gears/opensource/gears/canvas/canvas.cc#27 edit
... //depot/googleclient/gears/opensource/gears/canvas/canvas.h#22 edit
...
//depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.cc#23
edit
...
//depot/googleclient/gears/opensource/gears/canvas/canvas_rendering_context_2d.h#17
edit
... //depot/googleclient/gears/opensource/gears/test/manual/canvas.html#7 edit
182 delta lines: 73 added, 86 deleted, 23 changed
Also consider running:
g4 lint -c 10747844
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
