========================================================================
http://mondrian.corp.google.com/file/10892071///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=11
File
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc
(snapshot 11)
------------------------------------
Line 26: #ifdef OFFICIAL_BUILD
Remove the #ifdef OFFICIAL_BUILD guard.
========================================================================
http://mondrian.corp.google.com/file/10892071///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=5
File
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc
(snapshot 5)
------------------------------------
Line 241: // "Say" there's 1 drag file until we know more; extract the files.
On 2:58 pm, noel wrote:
> So why suggest that 0 more appropriate? In that case, we'd set g_drag_files
to
> 0, and return NULL to user javascript.
Technical nit, but javascript doesn't have NULL -- it has null, and it has
undefined.
But, what to return when dragging a directory -- whether to return 0, null, or
undefined -- is something I'll leave to when we do our cross-OS cross-browser
consistency pass. And consistency is why I want the Chrome code here to re-use
the same FileDragAndDropMetaData class that Firefox, IE and Safari all use.
> What does
> event.dataTransfer.getData("Text"|"URL") return if we return NULL when files
are
> being dragged?
On IE, getData returns null when there isn't any data of that flavor.
========================================================================
http://mondrian.corp.google.com/file/10892071///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=11
File
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc
(snapshot 11)
------------------------------------
Line 375: g_identity = 0;
Any reason why we reset g_identity to zero? Does that mean that, if JS calls
getDragData twice in succession, we will hit the disk twice?
========================================================================
--
To respond, reply to this email or visit
http://mondrian.corp.google.com/10892071
