======================================================================== http://mondrian.corp.google.com/file/11008311///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=5 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc (snapshot 5) ------------------------------------ Line 241: // "Say" there's 1 drag file until we know more; extract the files. On 4 May, noel wrote: > > And consistency is why I want the Chrome code here to re-use > > the same FileDragAndDropMetaData class that Firefox, IE and Safari > all use. > > That class as you've already mentioned is inconsistent and re-use is not my main > concern.
I'm not sure what you mean by that class being inconsistent. By consistent, I mean that it behaves the same on all browsers, on all OSes, and that is achieved by using the same code -- the d_a_d_u_common.cc code. Re-use and consistency come hand-in-hand. By having separate code for Chrome, you are making it behave inconsistently, compared to how Gears behaves on IE, Firefox and Safari, on Windows, Mac and Linux. As I said before, if there are bugs in the _common.cc code, such as it not being "solid" enough in the case of errors, then I wanted you to either fix the code in _common.cc, or add TODOs. Anyway, this CL is submitted, but I still wanted to clear up what I think was a miscommunication. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/11008311
