Hello playmobil,
I'd like you to do a code review. Please execute
g4 diff -c 11556277
or point your web browser to
http://mondrian/11556277
to review the following code:
Change 11556277 by nigel...@nigeltao-srcmacgears1 on 2009/06/18 14:12:41
*pending*
Unbreak file drag-and-drop for Firefox/Mac. Other browsers and
OSes are unaffected.
PRESUBMIT=passed
R=playmobil
[email protected]
DELTA=4 (4 added, 0 deleted, 0 changed)
OCL=11556277
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#21
edit
4 delta lines: 4 added, 0 deleted, 0 changed
Also consider running:
g4 lint -c 11556277
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11556277 by nigel...@nigeltao-srcmacgears1 on 2009/06/18 14:12:41
*pending*
Unbreak file drag-and-drop for Firefox/Mac. Other browsers and
OSes are unaffected.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#21
edit
====
//depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc#21
-
/Users/nigeltao/devel/srcmacgears1/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
====
# action=edit type=text
--- googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
2009-06-18 14:08:12.000000000 +1000
+++ googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_ff.cc
2009-06-18 14:10:29.000000000 +1000
@@ -623,11 +623,15 @@
filenames.clear();
break;
}
+#if !defined(OS_MACOSX)
+ // Mozilla's nsIFile::IsSpecial is not implemented for Mac OS X, and
+ // always fails (returning NS_ERROR_NOT_IMPLEMENTED).
bool_result = false;
if (NS_FAILED(local_file->IsSpecial(&bool_result)) || bool_result) {
filenames.clear();
break;
}
+#endif
filenames.push_back(std::string16(filename.get()));
}
