Hello andreip,
I'd like you to do a code review. Please execute
g4 diff -c 11545010
or point your web browser to
http://mondrian/11545010
to review the following code:
Change 11545010 by stevebl...@steveblock-gears1 on 2009/06/17 17:44:30 *pending*
Fixes a bug in a Geolocation unit test.
R=andreip
[email protected]
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=11545010
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#23
edit
1 delta lines: 0 added, 0 deleted, 1 changed
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
Change 11545010 by stevebl...@steveblock-gears1 on 2009/06/17 17:44:30 *pending*
Fixes a bug in a Geolocation unit test.
Affected files ...
...
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#23
edit
====
//depot/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js#23
-
c:\MyDocs\Gears1/googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
====
# action=edit type=text
---
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2009-06-17 17:39:17.000000000 +0100
+++
googleclient/gears/opensource/gears/test/testcases/internal_geolocation_tests.js
2009-05-13 15:21:26.000000000 +0100
@@ -317,7 +317,7 @@
error = internalTests.testGeolocationGetLocationFromResponse(
true, // HttpPost result
200, // status code
- '{"position": null}',
+ '{"location": null}',
0, // timestamp
dummy_server);
assertErrorEqual(error.POSITION_UNAVAILABLE, noGoodFixError, error);
