======================================================================== http://mondrian.corp.google.com/file/11937340///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=2 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc (snapshot 2) ------------------------------------ Line 94: bool AllowFileDrop(const char *file_drag_data) { Can AllowFileDrop just take no arguments (and instead just pass this.data() where it would pass file_drag_data)? ------------------------------------ Line 258: if (!drag->AllowFileDrop(drag->data())) I would do this at least a few lines up, before tokenization, i.e. as early as feasible. As an idea -- should the AllowFileDrop check simply be part of DragSession::GetDragData? ========================================================================
-- To respond, reply to this email or visit http://mondrian.corp.google.com/11937340
