======================================================================== http://mondrian.corp.google.com/file/11937340///depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc?a=2 File //depot/googleclient/gears/opensource/gears/desktop/drag_and_drop_utils_cr.cc (snapshot 2) ------------------------------------ Line 94: bool AllowFileDrop(const char *file_drag_data) { On 6:16 pm, nigeltao wrote: > Can AllowFileDrop just take no arguments (and instead just pass this.data() > where it would pass file_drag_data)?
Done. ------------------------------------ Line 258: if (!drag->AllowFileDrop(drag->data())) On 6:20 pm, nigeltao wrote: > I would do this at least a few lines up, before tokenization, i.e. as early as > feasible. As an idea -- should the AllowFileDrop check simply be part of > DragSession::GetDragData? Yes moved it up, and I think the GetDragData() and AllowFileDrop() calls should be done in one place (your idea hints at this), and the code reads that way now. ======================================================================== -- To respond, reply to this email or visit http://mondrian.corp.google.com/11937340
