Hello noel,
I'd like you to do a code review. Please execute
g4 diff -c 12193738
or point your web browser to
http://mondrian/12193738
to review the following code:
Change 12193738 by nigel...@nigeltao-srcgears1 on 2009/08/04 20:52:51 *pending*
Make desktop.extractMetaData now recognize MP3, PDF and ZIP files.
PRESUBMIT=passed
R=noel
[email protected]
DELTA=135 (108 added, 26 deleted, 1 changed)
OCL=12193738
Affected files ...
...
//depot/googleclient/gears/opensource/gears/desktop/meta_data_extraction.cc#6
edit
135 delta lines: 108 added, 26 deleted, 1 changed
Also consider running:
g4 lint -c 12193738
which verifies that the changelist doesn't introduce new style violations.
If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.
This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail [email protected].
