jonnybot0 commented on code in PR #256:
URL: https://github.com/apache/groovy-geb/pull/256#discussion_r1943652995
##########
gradle/libs.versions.toml:
##########
@@ -66,4 +74,3 @@ asciidoc = { id = 'org.asciidoctor.jvm.convert', version =
'4.0.4' }
asl2 = { id = 'com.energizedwork.asl2', version = '1.1' }
nexusPublish = { id = 'io.github.gradle-nexus.publish-plugin', version =
'2.0.0' }
node = { id = 'com.github.node-gradle.node', version = '7.1.0' }
-ratpackGroovy = { id = 'io.ratpack.ratpack-groovy', version.ref = 'ratpack' }
Review Comment:
Glad to see this gone. It does look like ratpack still lingers in
`geb.driver.CloudDriverFactorySpec`. Would it be too much scope creep to
refactor that out? Then we could remove ratpack dependencies entirely,
including module/geb-core/geb-core.gradle and this the libs.versions.toml.
If so, we can kick that to a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
