jonnybot0 commented on code in PR #256:
URL: https://github.com/apache/groovy-geb/pull/256#discussion_r1943662878
##########
buildSrc/src/main/groovy/org/gebish/gradle/ManualsPlugin.groovy:
##########
@@ -56,21 +60,25 @@ class ManualsPlugin implements Plugin<Project> {
}
}
- private void configureGenerateConfigPropertiesTask(
- Project project, BaseExtension baseExtension, ManualsExtension
manualsExtension
- ) {
- def currentVersion = manualsExtension.includedManuals.map {
- baseExtension.isSnapshot() ? it.last() : project.version
+ private void configureIndexTask(Project project) {
Review Comment:
Nitpicky thing: could we keep the extension objects as arguments to this
method? That makes the autocomplete in the IDE a little better than fetching
them by name later.
I've done this in a feedback branch on
https://github.com/apache/groovy-geb/pull/new/jonny-static-website-feedback
Feel free to just rip the changes, cherry-pick them, or whatever is easiest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
