Vampire commented on code in PR #274:
URL: https://github.com/apache/groovy-geb/pull/274#discussion_r2167268298
##########
module/geb-core/src/main/groovy/geb/js/JavascriptInterface.groovy:
##########
@@ -67,7 +68,21 @@ class JavascriptInterface {
throw new GebException("driver '$driver' can not execute
javascript")
}
Review Comment:
For the tested cases this might work, but we would anyway need the
after-the-fact-handling due to the possibility to mix-n-match multiple
arguments of various types, so I think this would not really help much as you
also concluded.
Also, since merging the `GString` PR there already is that type-filtering
already. :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
