jonnybot0 commented on code in PR #274:
URL: https://github.com/apache/groovy-geb/pull/274#discussion_r2178646501
##########
module/geb-core/src/main/groovy/geb/js/JavascriptInterface.groovy:
##########
@@ -67,7 +68,21 @@ class JavascriptInterface {
throw new GebException("driver '$driver' can not execute
javascript")
}
Review Comment:
> Also, since merging the GString PR there already is that type-filtering
already. :-D
True, but... https://github.com/apache/groovy-geb/pull/275 has me mulling
over whether there might not be a better way to support all these use cases.
Supporting GStrings seemed like a must have. Piling on type exceptions to the
argument array feels like duck typing abuse. I get why it's necessary, though,
and it looks analagous to how Selenium itself handles sorting the arguments by
their types under the hood.
I'm going to give myself a day or two more to mull it over. If I can't think
of a way that seems better to me, we'll roll with it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
