Hi PeterB, Werner, and Tomaz,
I'm in the process of merging Carlos' glist_dev (only the glist part) via
PeterB's patchset, and PeterC and I are a little confused by the following
change:
>This patch contains the required updates to the new autonumber code required
>in order to compile gschem with the new GList selection lists.
>
>+++ b/gschem/src/x_autonumber.c
>@@ -582,7 +582,8 @@ void autonumber_remove_number(AUTONUMBER_TEXT * autotext,
>OBJECT *o_current)
> if (slot_str != NULL && o_slot != NULL) {
> g_free(slot_str);
> /* delete the slot attribute */
>- o_selection_remove (autotext->toplevel->page_current->selection2_head,
>o_slot);
>+ GList *selection = autotext->toplevel->page_current->selection_list;
>+ o_selection_remove (&selection, o_slot);
Is this correct? Did you really want to pass in the address of
a local variable to o_selection_remove? Or is the right thing to do to
pass in the address of autotext->toplevel->page_current->selection_list?
Please advise.
Also I noticed that autonumber is hanging when trying to autonumber
the test schematics in gschem/test/autonumber* It seems to be getting stuck
in the hierarchy traversal. Please verify that this is working (or not)
before you update to CVS HEAD.
I will go ahead and commit the glist merge via PeterB's patchset
shortly.
-Ales
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
