On Sunday 17 December 2006 04:07, Ales Hvezda wrote:
> Hi PeterB, Werner, and Tomaz,
>
>
> I'm in the process of merging Carlos' glist_dev (only the glist part) via
> PeterB's patchset, and PeterC and I are a little confused by the following
>
> change:
> >This patch contains the required updates to the new autonumber code
> > required in order to compile gschem with the new GList selection lists.
> >
> >+++ b/gschem/src/x_autonumber.c
> >@@ -582,7 +582,8 @@ void autonumber_remove_number(AUTONUMBER_TEXT *
> > autotext, OBJECT *o_current)
> > if (slot_str != NULL && o_slot != NULL) {
> > g_free(slot_str);
> > /* delete the slot attribute */
> >- o_selection_remove (autotext->toplevel->page_current->selection2_head,
> >o_slot);
> >+ GList *selection = autotext->toplevel->page_current->selection_list;
> >+ o_selection_remove (&selection, o_slot);
>
> Is this correct? Did you really want to pass in the address of
> a local variable to o_selection_remove? Or is the right thing to do to
> pass in the address of autotext->toplevel->page_current->selection_list?
> Please advise.The latter. Sorry, my bad -- that was a patch Carlos & I threw together at the last minute to get stuff to compile, and I didn't test it properly. Peter -- Fisher Society committee http://tinyurl.com/o39w2 CUSBC novices, match and league secretary http://tinyurl.com/mwrc9 CU Spaceflight http://tinyurl.com/ognu2 v3sw6YChw7$ln3pr6$ck3ma8u7+Lw3+2m0l7Ci6e4+8t4Gb8en6g6Pa2Xs5Mr4p4 hackerkey.com peter-b.co.uk
pgpDBYE6EKasX.pgp
Description: PGP signature
_______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
