On Fri, 2007-11-16 at 14:48 -0200, Cesar Strauss wrote:
> Cesar Strauss wrote:
> > I finally got around to converting my (and Peter C's) monolithic patch
> > for gEDA/gaf to a series of git commits. I submitted most of them to the
> > patch tracker at sourceforge.
>
> I also published my git repository, with the MinGW patches, on repo.or.cz.
>
> Web view: http://repo.or.cz/w/geda-gaf/cesar.git
>
> Git URLs: git://repo.or.cz/geda-gaf/cesar.git
> http://repo.or.cz/r/geda-gaf/cesar.git
Cool ;)
One comment from the "pu" branch which I've reviewed the patches from:
@@ -399,11 +401,17 @@ static gchar *run_source_command (const gchar *command)
e->message);
g_error_free (e);
+#ifdef HAVE_SYS_WAIT_H
} else if (WIFSIGNALED(exit_status)) {
s_log_message ("Library command failed [%s]: Uncaught signal %i.\n",
command, WTERMSIG(exit_status));
+#endif
+#ifdef HAVE_SYS_WAIT_H
} else if (!WIFEXITED(exit_status)) {
+#else
+ } else if (exit_status != 0) {
+#endif
s_log_message ("Library command failed [%s]\n", command);
s_log_message("Error output was:\n%s\n", standard_error);
The two #ifdef HAVE_SYS_WAIT_H blocks can be neatly combined, otherwise
this is great.
If you don't have git commit access, let me know when you're happy for
the above patches to be pushed. I'll happily do it (probably sunday some
time), if you want. (Once I've build tested on Linux).
Best wishes,
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
