Hi,
On Sun, 2007-11-18 at 14:23 -0500, DJ Delorie wrote:
> Could you explain this change? It has nothing to do with whether or
> not a layer is exported.
>
> flash_drills = 0;
> - if (strcmp (name, "outline") == 0
> - || strcmp (name, "route") == 0)
> - flash_drills = 1;
> +
> + if (export_all_layers)
> + {
> + /* do nothing here */
> + }
> + else
> + {
> + if (strcmp (name, "outline") == 0
> + || strcmp (name, "route") == 0)
> + flash_drills = 1;
> + }
>
I did not fully grasp this one and assumed it was related to the
"outline" or "route" layers.
>
> Also, my personal preference is to invert the sense of the flag
> (internally, I like the check-for-export dialog setting), and use code
> like this:
>
> if (ignore_empty_layers
> && idx >= 0 && idx < max_layer && !print_layer[idx])
> return 0;
> }
>
> Mixing else-cases and inverted-active flags is, IMHO, confusing. I'd
> rather than flag say what you *are* doing in the conditional, rather
> than say what you *aren't* doing.
>
>
Ignoring empty layers differs from exporting all layers (empty or not).
I can, however, see your point.
Kind regards,
Bert Timmerman.
> _______________________________________________
> geda-dev mailing list
> [email protected]
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
