On Wed, Jan 09, 2008 at 09:38:03PM -0500, Stuart Brorson wrote:
> Gerbv has come a long way in the last few weeks. We're poised to do a
> general release of gerbv-2.0.0, which is a major overhaul of
> gerbv-1.X. I attach our release announcement below for you to see
> what's new.
>
> Before the general release, we are anxious to have some beta testers
> take gerbv-2.0.0 out for a test drive. Therefore, we are asking folks
> who read geda-dev to please take this opportunity to download the
> next-gen gerbv, try it out, and give us feedback. You may download
> gerbv-2.0.0-beta from SourceForge:
>
> http://sourceforge.net/projects/gerbv/
>
> While you're there, please check out the new screenshots showing all
> the excellent new features added by the gerbv team.
>
> We are very interested in hearing about any bugs or misfeatures you
> encounter while trying out gerbv-2.0.0-beta. If you experience any
> problems with the new gerbv, please either post your complaints on
> this list, or e-mail me directly at sdb (shift 2) cloud (period) net.
I tried to compile it on a PowerMac and I got one of the classical
warnings on machines on which char is unsigned by default: from a
cursory look at the code, most results of gerb_fgetc are stored into
an int, except at one point where it is stored into a char before
being compared to EOF. This doesn't fly and I've sometimes been bitten
by this bug even if "\377" is very uncommon in the character sets I use
(once in a Microsoft utility). Patch is very simple (the first hunk
merely fixes a typo I spotted while looking for gerb_fgetc uses):
Index: gerber.c
===================================================================
RCS file: /cvsroot/gerbv/gerbv/src/gerber.c,v
retrieving revision 1.104
diff -u -r1.104 gerber.c
--- gerber.c 8 Jan 2008 00:01:12 -0000 1.104
+++ gerber.c 11 Jan 2008 11:20:21 -0000
@@ -115,7 +115,7 @@
gboolean foundEOF = FALSE;
while ((read = gerb_fgetc(fd)) != EOF) {
- /* figure out the scale, since we need to normailize
+ /* figure out the scale, since we need to normalize
all dimensions to inches */
if (state->state->unit == MM)
scale = 25.4;
@@ -217,7 +217,7 @@
dprintf("... Found %% code\n");
parse_rs274x(levelOfRecursion, fd, image, state, curr_net, stats,
directoryPath);
while (1){
- char c=gerb_fgetc(fd);
+ int c=gerb_fgetc(fd);
if(c==EOF || c=='%')
break;
}
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
