der Mouse wrote:

> - add_timer's interface design looks good, but there's a nasty gotcha
>    lurking; the auto-save code assumes the .ptr member of a timer's
>    returned hidval is not a nil pointer.  (Why design a nice general
>    interface and then violate it like that?  Odd.  Two different
>    people, perhaps?)

or more.  One thing you may find about PCB is that its history is long. 
  It was written for the atari a very long time ago and later ported to 
X.    I haven't heard from the original author, Thomas Nau, in ages. 
Harry Eaton took pcb a long ways from the original versions and still 
does some work from time to time.  For quite some time PCB used Xaw and 
the gui and core were pretty tied to each other.  Then Bill Wilson 
reworked it to use gtk and then later DJ came up with the current HID 
approach.  DJ wrote the lesstif HID and Bill Wilson did a bunch of the 
work to create the GTK HID.  I also worked on bits of the GTK HID. 
We've had a handful of others involved too.  So, there are certainly 
places where things can be better and where code has had many hands on it.

> - Why does attribtue_dialog exist?  As far as I can tell it's never
>    referred to anywhere; did I miss something?

I think it is used by the export and print dialogs at least in the gtk 
HID.  But I don't think the core ever directly calls the attribute 
dialog currently.

For the export/print dialogs, the gui takes a look at the attribute list 
for the export HID and builds the form on the fly.  That makes the 
export dialog for new exporters come for free.

-Dan


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to