Hello Ed, [EMAIL PROTECTED] writes: > [...] > There should only be one icon factory per application. However, > x_icons_init() has an initialization dependency on i_vars_set(), or > more specifically, i_vars_libgeda_set(). To fix this problem, would > it be logical to change the initialization function signature to > x_icons_init(const gchar* bitmap directory).
That is what I tried to say in the third point. > Then, move the function > call out of x_window_setup() and into main_prog(), place immediately > after x_window_set_default_icon() such that:? Yes absolutely. > [...] > Which brings up another potential refactor. The > x_window_set_default_icon() function might need to move to x_icons.c? It looks like a good thing to do. Regards, Patrick _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
