Hello Ed,
Overall looks good. Still two things on the patchset you sent:
- The point of reviewing code before integrating it in the main tree
is to avoid "modify-then-fix" has much as possible. Until the
changes are integrated you are free to tweak your patches, in this
case to take into account the comments from my message.
As a result, what we are expecting is a single 'perfect' patch for
your patches 1 and 2.
- I see you are adding new entries to the toolbar before having
the new toolbar with actions and everything done. This is a bad
idea. It is easier for everybody to first fix/modify things and
then add.
Only a quick look so far, may be more later. Please resubmit your
patches with the above comments fixed.
Regards,
Patrick
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
