Hi; On Tue, Sep 2, 2008 at 3:56 PM, Stuart Brorson <[EMAIL PROTECTED]> wrote: > I applied your patch, and it went in cleanly. Thanks! > > Thereafter, I rebuilt gerbv, and it seemed to run fine on my small > handful of tests. Therefore I checked your change into CVS.
Thank you! > And Ineiev, if you could please explain what bug was present > in the last version, and how one might trigger it in testing, then we > can all try to reproduce this scenario and verify that your change > fixed the problem. X11 line drawing routines accept short int arguments as coordinates of line ends. When drawing a long measure line in large zooms, the line ends may go out of the limits of short int. To limit the coordinates I introduced a function, trim_point, that was buggy. It was intended to move a point along the measure line to a position that was near enough to the origin of coordinates. Before 02sept2008.trim_point.diff it worked incorrectly: sometimes it didn't limit the coordinates, sometimes it did it wrongly; the visible effects were 1) when zooming in on an end of a long measure line, the line changed it's direction; 2) when zooming in on a middle of such a line, the line disappeared. The effect was likely to appear on the last zoomins. Regards, Ineiev _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
