On Sat, 2008-09-27 at 19:38 -0400, Ales Hvezda wrote: > Hi Peter, > > Thanks for working on and commiting this path code.
Thanks :). It feels good to have it pushed. I'm slowly plodding through the various patches I have stacked up. The cairo stuff will still require a bit of effort yet unfortunately. [snip] > >Note, that the last "1" on the "p ...." line means "one further line of > >path string. You'd want to drop that if you moved to the [...] syntax. > > I do like the multi-line syntax better (with an added line count). > Though we have a nice mix of things (text with count, attributes/embedded > symbols with delimiters, and pictures that end with a dot). I'm tired. Are you saying you prefer without the "[]", but that we should emit each segment on multiple lines by default? Peter B said he liked my original syntax best. Not sure whether this was relating to the [] deimeters, or the multi-line outout though. > Also, I'm not too keen on using a lower-case "p" for the path > identifer. It might confuse people who will think that p and P are > the same. How about something like H (patH)? There are no other lower > case object identifiers. That niggled with me too. "H" sounds good, please bug me to change it ;) > I'm willing to be convinced in either direction. Also, once > we lock things down, please update the file format documentation on the > wiki and bump the file format version # (in libgeda/defines.h: > > #define FILEFORMAT_VERSION 1 Ok, had forgotten about that part of the file-format versioning. I Had thought it was done based on the release version. > Also, one minor buglet: > > - Printing npn-1.sym to a postscript file, renders the filled arrows in > green (should be black in output-color "disabled" mode). Thats what I like to hear... bug reports from people who've tested the code ;) I usually emit postscript in colour, so didn't notice that one. Please bug me to fix it if I've not done so by the next time we're about to make a release. Thanks for testing! -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
